Use Semantic Versioning for Git tags #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit regular expressions for dealing with Git tags have been removed and replaced with a Semantic Versioning library. This should improve maintainability there by offloading the version voodoo as well as allow for future improvements such as warning for major version bumps and more. An imporant note however is that this removes support for version tags which consist of just one number of in an X.Y format, as Semantic Versioning mandates a complete X.Y.Z version tag at the very least.
Simplify the flow with an if..elsif..else instead of a switchy-casey. Really, the flow is simple enough there - just use ifs.
sigv
referenced
this pull request
Apr 5, 2018
some modules have weird tags. e.g. puppetlabs-git ``` 10:23 $ git ls-remote https://github.com/puppetlabs/puppetlabs-git.git | tail -3 cfbf74dbb370f00d1349d8589ba0d963d5d503eb refs/tags/0.4.0^{} a0cf10a8cec8728abb008fdd778e243e84dde62c refs/tags/0.5.0 f7e4ff5cc0b8e887ff07579bb383ce9e173fb93c refs/tags/0.5.0^{} ``` ra10ke reports this as outdated: git is OUTDATED: 0.5.0 vs 0.5.0^{} This fix ensures that we unly use correct version tags
|
A-MA-ZING thanks a lot! |
sigv
commented
Apr 5, 2018
| nil | ||
| end | ||
| end.select { |tag| !tag.nil? }.sort.last.to_s.downcase | ||
| latest_ref = tags.detect { |tag| tag.downcase == latest_tag || tag.downcase == latest_tag[1..-1] } |
There was a problem hiding this comment.
In retrospect, tag.downcase == latest_tag[1..-1] here could use an extra latest_tag[0] == 'v' check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the quick notes in f20ba12 here is a proposal for dealing with Git tags without using regular expressions - use Semantic Versioning instead.
This PR removes support for
XandX.Yversion tags, but supportsvX.Y.Zalong withX.Y.Zand full SemVer tags such asv2.3.1-rc.2+20180405. If there is a reason to add support for theXandX.Yformats, those can be squeezed in.