Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore invalid ref #15

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Apr 5, 2018

some modules have weird tags.
e.g.
puppetlabs-git

git ls-remote https://github.com/puppetlabs/puppetlabs-git.git | tail -3
cfbf74dbb370f00d1349d8589ba0d963d5d503eb	refs/tags/0.4.0^{}
a0cf10a8cec8728abb008fdd778e243e84dde62c	refs/tags/0.5.0
f7e4ff5cc0b8e887ff07579bb383ce9e173fb93c	refs/tags/0.5.0^{}

ra10ke reports this as outdated:

git is OUTDATED: 0.5.0 vs 0.5.0^{}

This fix ensures that we only use correct version tags

some modules have weird tags.
e.g.
puppetlabs-git
```
10:23 $ git ls-remote https://github.com/puppetlabs/puppetlabs-git.git | tail -3
cfbf74dbb370f00d1349d8589ba0d963d5d503eb	refs/tags/0.4.0^{}
a0cf10a8cec8728abb008fdd778e243e84dde62c	refs/tags/0.5.0
f7e4ff5cc0b8e887ff07579bb383ce9e173fb93c	refs/tags/0.5.0^{}
```
ra10ke reports this as outdated:

git is OUTDATED: 0.5.0 vs 0.5.0^{}

This fix ensures that we unly use correct version tags
@tuxmea tuxmea requested a review from bastelfreak April 5, 2018 08:26
@bastelfreak
Copy link
Member

what the hell...

@bastelfreak bastelfreak merged commit 2cff9f1 into voxpupuli:master Apr 5, 2018
@tuxmea tuxmea deleted the ignore_invalid_refs branch June 18, 2018 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants