Add Arch Linux support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meaks it easier to change the logic for an individual OS which may behave differently.
Arch Linux has a rolling release so it ignores the actual releases. It also only supports the latest Puppet version so it doesn't make sense to look at the actually supported Puppet versions.
ekohl
commented
Feb 13, 2022
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def github_action_test_matrix(use_fqdn: false, pidfile_workaround: false) | ||
| matrix_include = [] |
There was a problem hiding this comment.
This is still not as pretty as I'd like - yield in Python feels much more natural than in Ruby.
bastelfreak
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
This passes for me in https://github.com/voxpupuli/puppet-borg/runs/5173999953?check_suite_focus=true, any objections in merging it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #15. I took a slightly different approach by splitting the GHA test matrix (which is wrongly named, it should really be
beaker_test_matrix) into two functions: one to yield the tuple of OS, release and Puppet version and one to convert that into the actual output.It doesn't implement it in
beaker_setfilesbut that is now unused and I'd rather deprecate it instead and remove it in a major release.