Update README.md with badges; publish gem to GHA/rubygems; add missing license #17
Conversation
| @@ -1,3 +1,7 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| gemspec | |||
|
|
|||
| group :release do | |||
There was a problem hiding this comment.
Thoughts on not installing this by default?
| group :release do | |
| group :release, optional: true do |
It does mean we need to update your release workflow to set BUNDLE_WITH but it makes the initial install faster.
There was a problem hiding this comment.
Doesn't optional: false make more sense here? We only need it locally for generating the changelog, but not in general so it could default to false?
There was a problem hiding this comment.
https://bundler.io/man/gemfile.5.html#BLOCK-FORM-OF-SOURCE-GIT-PATH-GROUP-and-PLATFORMS
In the case of the group block form the :optional option can be given to prevent a group from being installed unless listed in the --with option given to the bundle install command.
So I think optional: true can be read as default: false.
|
|
||
| To make a new release, please do: | ||
| * Update the version in the puppet_metadata.gemspec file | ||
| * Install gems with `bundle install --with release --path .vendor` |
There was a problem hiding this comment.
bundle install --with is deprecated. I think now it's bundle config with release && ..
There was a problem hiding this comment.
ah you're right. We really need to template the README.md somehow to get this consistent :(
No description provided.