Support BEAKER_FACTER_* env vars in beaker testing #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something to think about: puppet-zabbix could use this, but there we may need to skip combos: EL7 & Zabbix 6 for example. |
Answering here, just for context: no, this needs no skip as the zabbix6 agent is well supported on EL7, so you only need to skip the server bits, and that the tests already do. |
bastelfreak
approved these changes
Oct 11, 2023
This only presents a name and environment variables. It is intended to replace github_action_test_matrix, which is now deprecated.
This changes things so you can run a test matrix by providing an additional fact. The use case is that you have a test suite for your software and want to support multiple versions of that software. For example, in puppet-pulpcore there are versions 3.21, 3.22 and 3.28 supported at the same time. Rather than designing the test suite to first test x, then y and then z while cleaning up in between, this allows providing the version as a fact (so setup_acceptance_node.rb can set up repos). You then expand the test matrix. It also includes the version number so it's easy to see which version of the software is being tested. That it can use parallelism for this is just a side effect, but a nice one. To make it more flexible the config for GHA is changed by providing puppet_beaker_test_matrix. This only provides a name and a set of environment variables. This means other CI systems could also use this. Only a single fact can be provided. Generating the whole matrix was too complex and not needed for my use case. Because it's only providing a name and a set of env vars, it could be extended in the future.
|
Now updated with tests and I think it's ready. |
bastelfreak
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes things so you can run a test matrix by providing an additional fact.
The use case is that you have a test suite for your software and want to support multiple versions of that software. For example, in puppet-pulpcore there are versions 3.21, 3.22 and 3.28 supported at the same time. Rather than designing the test suite to first test x, then y and then z while cleaning up in between, this allows providing the version as a fact (so
setup_acceptance_node.rbcan set up repos). You then expand the test matrix. It also includes the version number so it's easy to see which version of the software is being tested. That it can use parallelism for this is just a side effect, but a nice one.To make it more flexible the config for GHA is changed by providing
puppet_beaker_test_matrix. This only provides a name and a set of environment variables. This means other CI systems could also use this.Only a single fact can be provided. Generating the whole matrix was too complex and not needed for my use case. Because it's only providing a name and a set of env vars, it could be extended in the future.
Right now it doesn't have documentation, which should be added before it's merged but this at least allows for review.