add zabbix-server options StartReportWriters and WebServiceURL. #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options require version 5.4.
ade2205 to
3abd361
Compare
bastelfreak
reviewed
Jan 12, 2022
bastelfreak
reviewed
Jan 12, 2022
templates/zabbix_server.conf.erb
Outdated
| # Range: 0-100 | ||
| # Default: | ||
| # StartReportWriters=0 | ||
| <% if @startreportwriters %>VaultDBPath=<%= @startreportwriters -%><% end %> |
There was a problem hiding this comment.
copy and paste mistake?
Suggested change
| <% if @startreportwriters %>VaultDBPath=<%= @startreportwriters -%><% end %> | |
| <% if @startreportwriters %>StartReportWriters=<%= @startreportwriters -%><% end %> |
There was a problem hiding this comment.
How did this pass the test?
There was a problem hiding this comment.
mhm good question. very odd.
There was a problem hiding this comment.
the reason for this was: It didn't pass the test
bastelfreak
reviewed
Jan 12, 2022
templates/zabbix_server.conf.erb
Outdated
| # Mandatory: no | ||
| # Default: | ||
| # WebServiceURL= | ||
| <% if @webserviceurl %>VaultDBPath=<%= @webserviceurl -%><% end %> |
There was a problem hiding this comment.
copy and paste mistake?
Suggested change
| <% if @webserviceurl %>VaultDBPath=<%= @webserviceurl -%><% end %> | |
| <% if @webserviceurl %>WebServiceURL=<%= @webserviceurl -%><% end %> |
bastelfreak
reviewed
Jan 13, 2022
Poor single soul who requests this over gopher ;-) Co-authored-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
approved these changes
Jan 13, 2022
This will mostly be localhost, I expect.
bastelfreak
approved these changes
Jan 13, 2022
root-expert
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options require version 5.4.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues