-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zabbix 5.4 support #776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't fail if version is not supported by the gem, until the gem has been updated for zabbix 5.4 Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
bastelfreak
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is backwards incompatible because the application support is being droped. Please check if we can keep it until we drop support for those old versions that still have it.
8d3455c
to
ad8408c
Compare
* Zabbix applications were replaced with Item tags in version 5.4 * applications and screens parameters were removed from configurations.import * selectApplications parameter was removed from templates.get in version 5.4 Source: https://www.zabbix.com/documentation/5.4/manual/api/changes_5.2_-_5.4 Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
bb425f8
to
a1a3ab0
Compare
bastelfreak
reviewed
Jul 30, 2021
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
…d on RHEL7 * zabbix 5.4 changed the location of the sql scripts, now there's a standalone package called zabbix-sql-scripts which installs the scripts in `/usr/share/doc/zabbix-sql-scripts/* Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
a1a3ab0
to
53c126d
Compare
bastelfreak
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds Zabbix 5.4 support.
zabbixapi gem doesn't have support for 5.4 version yet.
For now I passed
ignore_version
parameter. It seems to be working fine as there aren't any API changes that would break the gem. If we don't feel comfortable merging this I may open a PR on zabbixapi repo.This Pull Request (PR) fixes the following issues
Closes #773 (Thanks for pointing out!)