Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zabbix 5.4 support #776

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Conversation

root-expert
Copy link
Member

Pull Request (PR) description

Adds Zabbix 5.4 support.
zabbixapi gem doesn't have support for 5.4 version yet.
For now I passed ignore_version parameter. It seems to be working fine as there aren't any API changes that would break the gem. If we don't feel comfortable merging this I may open a PR on zabbixapi repo.

This Pull Request (PR) fixes the following issues

Closes #773 (Thanks for pointing out!)

* Don't fail if version is not supported by the gem, until the gem has been updated for zabbix 5.4

Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
@bastelfreak bastelfreak changed the title Zabbix 5.4 support Add Zabbix 5.4 support Jul 29, 2021
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is backwards incompatible because the application support is being droped. Please check if we can keep it until we drop support for those old versions that still have it.

@root-expert root-expert force-pushed the zabbix-5.4-support branch 4 times, most recently from 8d3455c to ad8408c Compare July 29, 2021 19:12
@bastelfreak bastelfreak added enhancement New feature or request and removed backwards-incompatible labels Jul 29, 2021
* Zabbix applications were replaced with Item tags in version 5.4
* applications and screens parameters were removed from configurations.import
* selectApplications parameter was removed from templates.get in version 5.4

Source: https://www.zabbix.com/documentation/5.4/manual/api/changes_5.2_-_5.4

Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
@root-expert root-expert force-pushed the zabbix-5.4-support branch 2 times, most recently from bb425f8 to a1a3ab0 Compare July 29, 2021 20:46
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
…d on RHEL7

* zabbix 5.4 changed the location of the sql scripts, now there's a standalone package called zabbix-sql-scripts which installs the scripts in `/usr/share/doc/zabbix-sql-scripts/*

Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
@bastelfreak bastelfreak merged commit 7c35104 into voxpupuli:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zabbix SQL file location has changed
2 participants