Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Puppet 5 support #742

Merged
merged 5 commits into from
Mar 7, 2021
Merged

Drop Puppet 5 support #742

merged 5 commits into from
Mar 7, 2021

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak self-assigned this Feb 28, 2021
@root-expert root-expert mentioned this pull request Feb 28, 2021
Merged
@kenyon
Copy link
Member

kenyon commented Mar 1, 2021

The error is here: https://github.com/voxpupuli/puppet-zabbix/pull/742/checks?check_run_id=1999631797#step:5:8194

This is the first result in Google: https://tickets.puppetlabs.com/browse/MODULES-3466

🤔

@root-expert
Copy link
Member

root-expert commented Mar 1, 2021 •
edited
Loading

Maybe exporting language variables like so:

export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8
export LC_ALL=en_US.UTF-8

when the docker container starts could help?

@bastelfreak
Copy link
Member Author

whyyyyyyyyyy is that error coming up again :(. @trevor-vaughan any idea how we can fix that? should beaker-docker set those env vars or modify the puppetlabs-postgresql module or something else?

@bastelfreak
Copy link
Member Author

this also includes #744

@root-expert root-expert mentioned this pull request Mar 4, 2021
Closed
@tuxmea tuxmea mentioned this pull request Mar 4, 2021
Closed
@bastelfreak bastelfreak changed the title Drop Puppet 5 support, enable Puppet 7 support Drop Puppet 5 support Mar 6, 2021
@bastelfreak bastelfreak force-pushed the puppet7 branch 2 times, most recently from 99767f4 to 79f63df Compare March 6, 2021 20:57
@bastelfreak
Copy link
Member Author

This PR now includes #746 and #744

@kenyon kenyon mentioned this pull request Mar 7, 2021
Merged
@bastelfreak bastelfreak merged commit 07c6bca into voxpupuli:master Mar 7, 2021
@bastelfreak bastelfreak deleted the puppet7 branch March 7, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

Assignees

@bastelfreak bastelfreak

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastelfreak @kenyon @root-expert @baurmatt