modulesync 3.0.0 & puppet-lint fixes & rubocop fixes #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bastelfreak Could you look into the failing tests? |
|
oh why doesn't centos apply anymore :( |
|
Was there a version change? |
baurmatt
reviewed
Aug 26, 2020
f791acb to
000daf1
Compare
llowder
approved these changes
Aug 26, 2020
000daf1 to
7770422
Compare
ekohl
requested changes
Aug 26, 2020
alexjfisher
reviewed
Aug 29, 2020
| @@ -1,6 +1,7 @@ | |||
| require 'spec_helper_acceptance' | |||
| require 'serverspec_type_zabbixapi' | |||
|
|
|||
| # rubocop:disable RSpec/LetBeforeExamples | |||
There was a problem hiding this comment.
Did this need to be disabled?
There was a problem hiding this comment.
I assume so. Rubocop complained that this line is now useless and needs to be removed.
There was a problem hiding this comment.
ah, wrong comment. yes, rubocop said there are multiple issues for that cop. I wasn't able to fix this quickly and we really need to get this modulesync merged, so I disabled it.
7770422 to
6eff395
Compare
6eff395 to
c79db29
Compare
dhollinger
approved these changes
Sep 2, 2020
ekohl
reviewed
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues