Add ability to stop the agent

[mkilchhofer]

Pull Request (PR) description

For our "IoT use case" we want to completely configure a mini server during the staging process. When a technician installs the device to its final position (in a vehicle), we want to activate the monitoring agent.

This PR adds the ability to start/stop the agent and to enable/disable the agents automatic startup during boot.

--> Could someone help me writing my first rspec tests for this feature?

[bastelfreak]

Can you instead use the stdlib datatype for this:
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/ensure/service.pp#L1

[bastelfreak]

Hi @mkilchhofer, thanks for the contribution! Did you already check https://github.com/voxpupuli/puppet-zabbix/blob/master/spec/classes/agent_spec.rb? That is the file with all the related rspec-puppet tests for the agent. If you've any questions I suggest you join our slack channel at https://slack.puppet.com or our IRC channel #voxppuli on freenode. That would make it way easier to discuss proper testing and an rspec walkthrough.

[bastelfreak]

can you fix the = alignment here?

[mkilchhofer]

yup :)

[mkilchhofer]

Hi @mkilchhofer, thanks for the contribution! Did you already check https://github.com/voxpupuli/puppet-zabbix/blob/master/spec/classes/agent_spec.rb? That is the file with all the related rspec-puppet tests for the agent. If you've any questions I suggest you join our slack channel at https://slack.puppet.com or our IRC channel #voxppuli on freenode. That would make it way easier to discuss proper testing and an rspec walkthrough.

I will have a look into rspec tests in the next week. I had my problems to run them on the rhel machines at work (ruby2.0). But on my fedora laptop (ruby2.5+), your mentioned spec file works fine.

[bastelfreak]

We don't support ruby2.0 and 2.1 anymore. Both are EOL since ages. Ruby2.2 and newer should work.

[mkilchhofer]

Is something like this enough:

diff --git a/spec/classes/agent_spec.rb b/spec/classes/agent_spec.rb
index da00269..0be24d7 100644
--- a/spec/classes/agent_spec.rb
+++ b/spec/classes/agent_spec.rb
@@ -243,6 +243,25 @@ describe 'zabbix::agent' do
 
         it { is_expected.to contain_file(config_path).without_content %r{^ListenIP=} }
       end
+
+      context 'when declaring service_ensure is stopped and service_enable false' do
+        package = 'zabbix-agent'
+
+        let :params do
+          {
+            service_ensure: 'stopped',
+            service_enable: false
+          }
+        end
+
+        it do
+          is_expected.to contain_service('zabbix-agent').with(
+            ensure:     'stopped',
+            enable:     false,
+            require:    "Package[#{package}]"
+          )
+        end
+      end
     end
   end
 end

[bastelfreak]

@mkilchhofer yes the test looks fine. I restarted the failed travis job.