Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to disable privatetmp in the server systemd file. #522

Closed
wants to merge 13 commits into from

Conversation

ranzbak
Copy link

@ranzbak ranzbak commented Aug 9, 2018

Pull Request (PR) description

This pool request adds a switch to the server class, to enable/disable the privatetmp option in the zabbix-server systemd file.

This Pull Request (PR) fixes the following issues

PrivateTmp always enabled, this messes with SNMP trap configurations #521

@bastelfreak
Copy link
Member

Hi @ranzbak, thanks for the PR. I'm wondering if this is the right solution to the problem. This means the shared directory will be /tmp? I don't think that this is a good idea. Wouldn't it make more sense to create a new directory which is shared between both processes exclusively?

@bastelfreak
Copy link
Member

Please rebase after #524 got merged. That will fix the failing beaker jobs

@bastelfreak bastelfreak added needs-feedback Further information is requested needs-rebase labels Aug 11, 2018
@ranzbak
Copy link
Author

ranzbak commented Aug 22, 2018

What also could be a solution is to add : JoinsNamespaceOf=
To the systemd file so both the feeder and Zabbix share the same tmp directory.
But this doesn't make debugging the setup easy, at least for debugging the private tmp should be configurable.

bastelfreak and others added 12 commits August 22, 2018 14:46
This is a transitive dependency. In the past we pulled it in via beaker
itself. Since the recent beaker/beaker-rspec we need to require it
explicitly. The new beaker version also requires us to set
BEAKER_IS_PE=no for each acceptance test, otherwise it tries to install
Puppet Enterprise...
@ranzbak
Copy link
Author

ranzbak commented Aug 22, 2018

Also rebase done :-)

@bastelfreak
Copy link
Member

bastelfreak commented Nov 2, 2018

@ranzbak the rebase doesn't look correct, can you give it another shot? If you need any help with git, feel free to join our slack channel at https://slack.puppet.com or our IRC channel #voxpupuli on freenode.

@Fabian1976
Copy link
Contributor

I also ran in to this issue. I fixed it by letting snmptt write the file in this location:
/var/log/zabbix/zabbix_traps.tmp
And setting the trapper file of the server process to the same location.

@bastelfreak
Copy link
Member

@Fabian1976 are you interested in finishing this PR?

@Fabian1976
Copy link
Contributor

@bastelfreak No, not really :) I agree with you that this isn't the right solution to "fix" it. Just write the trapper file to another folder (not /tmp) where it can also be managed by logrotate and archived if you want to have an archive.

@bastelfreak
Copy link
Member

Hi. I'm going to close this PR. Please reopen it if you still think this is a good idea and we can discuss it here or on slack http://slack.puppet.com/ or our IRC channel #voxpupuli on freenode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants