only add --foreground on 3.0 and newer #396
Merged
+193
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
266bfaf to
6b2eb82
Compare
We added the --foreground to honor the systemd upstream recommendations. However, this option is only available in zabbix 3.0 and newer. 2.2 still has support. Additional information: voxpupuli#382 http://www.zabbix.com/life_cycle_and_release_policy https://www.zabbix.com/documentation/2.4/manpages/zabbix_agentd https://www.zabbix.com/documentation/3.0/manpages/zabbix_agentd
6b2eb82 to
3bb356a
Compare
dhollinger
approved these changes
Jun 3, 2017
|
I just noticed that this patch didn't fix it completely 😢 We now provide sane defaults, but it doesn't work if somebody explicitly sets a zabbix version like this: class { 'zabbix::agent':
server => '192.168.20.11',
zabbix_version => '2.4'
}the logic in the params.pp only honors the default value.I will try to spin up a another patch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the --foreground to honor the systemd upstream recommendations.
However, this option is only available in zabbix 3.0 and newer. 2.2
still has support. Additional information:
#382
http://www.zabbix.com/life_cycle_and_release_policy
https://www.zabbix.com/documentation/2.4/manpages/zabbix_agentd
https://www.zabbix.com/documentation/3.0/manpages/zabbix_agentd