Migrate tests to rspec-puppet-facts #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4ef917 to
cd6fa7d
Compare
This was referenced May 21, 2017
7f1303f to
ca88993
Compare
|
There are several failures in the travis tests. Is that expected? Otherwise, the changes look great! |
|
well, kind of expected. I'm not done yet with migrating them to rspec-puppet-facts. |
46d23df to
f323383
Compare
803fadc to
9e96ef9
Compare
this got mainly written for pure redhat and only works there. This is too much work to 'just convert it to all OS'. This now uses rspec-puppet-facts but still only tests on CentOS + RedHat.
|
Looks like there are a couple of RoboCop failures. If this is ready, I will merge once those RoboCop issues are fixed. |
dhollinger
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need rspec-puppet-facts for #382