Strict variables fix for selinux_config_mode #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Dec 7, 2016
| @@ -3,4 +3,3 @@ concat_basedir: "/tmp" | |||
| ipaddress: "172.16.254.254" | |||
| is_pe: false | |||
| macaddress: "AA:AA:AA:AA:AA:AA" | |||
| selinux_config_mode: "disabled" | |||
There was a problem hiding this comment.
This was making the tests pass even though on systems with selinux disabled, this fact doesn't exist.
You'd have thought the fact would return disabled, but if the selinux fact is false, the selinux_config_mode fact isn't returned at all.
The facter 3 code is a bit difficult to read, but in facter 2 there's a confine :selinux => true
There was a problem hiding this comment.
this is managed via msycn, we should probably also remove it there.
There was a problem hiding this comment.
oh really, all modules get this fact set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #GH-325