Default web_config_owner/group correctly #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #312 |
0ba1c1e to
c50c64b
Compare
When apache hasn't been evaluated `getvar('::apache::user')` should
return `undef`.
This commit attempts to address 2 issues.
1) In puppet 4 `''` (empty string) != `undef`
2) In stdlib < 4.13.0 instead of `undef`, `getvar('::apache::user')`
returns a literal string `'class ::apache has not been evaluated'`. This
is a bug that was fixed, but it's not too hard to work around.
c50c64b to
616fcd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When apache hasn't been evaluated
getvar('::apache::user')shouldreturn
undef.This commit attempts to address 2 issues.
''(empty string) !=undefundef,getvar('::apache::user')returns a literal string
'class ::apache has not been evaluated'. Thisis a bug that was fixed, but it's not too hard to work around.