Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case we are not using Apache we should have an option to define ow… #307

Merged
merged 3 commits into from
Nov 4, 2016

Conversation

admont
Copy link
Contributor

@admont admont commented Nov 2, 2016

Puppet will fail with errors in case we are not using apache module:
Error: Could not find user class ::apache has not been evaluated
Error: Could not find group class ::apache has not been evaluated

for these variables:
$apache_user = getvar('::apache::user')
$apache_group = getvar('::apache::group')

In my commit you can find a possible solution for this problem.

@bastelfreak
Copy link
Member

Hi @admont, thanks for the PR. Do you think you can add tests for thisß

@bastelfreak
Copy link
Member

Hi, could you take a look at the rubocop issues and merge them into your last commit?

@admont
Copy link
Contributor Author

admont commented Nov 3, 2016

Yes, I will check a bit later, busy with other stuff

@bastelfreak bastelfreak merged commit 9923919 into voxpupuli:master Nov 4, 2016
@bastelfreak
Copy link
Member

thanks @admont!

@admont
Copy link
Contributor Author

admont commented Nov 4, 2016

Thank you @bastelfreak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants