Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rspec #203

Merged
merged 34 commits into from
Apr 11, 2016
Merged

Update rspec #203

merged 34 commits into from
Apr 11, 2016
+489 −248

Conversation

bastelfreak
Copy link
Member

I'm playing around a bit and updating stuff

  • remove much trailing whitespace
  • bumped rubocop to latest
  • adjusted rubocop conf
  • update code to be ruobcop complaint
  • add missing facts in spec tests
  • use correct scoping in classes
  • implement inheritance where needed
  • fix tests

@bastelfreak
Copy link
Member Author

I really really like the new HashSyntax in Ruby:

{symbol: 'myvalue'}

We could enforce this be enabling HashSyntax in rubocop. Any thoughts on this? This isn't valid syntax on anything prior Ruby1.9.3, but the modules doesn't support older versions.

@bastelfreak
Copy link
Member Author

w00p w00p almost done \o/

@bastelfreak
Copy link
Member Author

we're getting closer

@bastelfreak bastelfreak changed the title [WIP]Update rspec Update rspec Apr 9, 2016
@bastelfreak
Copy link
Member Author

Can someone please take a look and review? If anybody wants to adjust the .rubocop.yml: I'm willing to contribute a bit more work, especially in the new HashSyntax, but in a seperate PR.

bastelfreak added 23 commits April 9, 2016 23:01
@bastelfreak
remove duplicated keys in hash
12d6ebd 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
remove trailing whitespace
684a3a6 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
use ternary instead of if/else block
a3a60f3 
this fixes Style/ConditionalAssignment from rubocop

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
use ternary instead of if/else codeblock
dfbecb5 
this fixes Style/ConditionalAssignment from rubocop 0.39.0

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
use ternary instead of if/else block
1c71ce7 
fixes Style/ConditionalAssignment

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
Don't write Rescue into variable e
de95a99 
fixes "assigned but unused variable"

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
cast var to string instead of interpolation
bb556c1 
TODO: maybe we can supply the int directly without converting it?
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
bump rubocop to 0.39.0 and update .rubcop.yml
3068edf 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
also ignore .vendor which is common on many tools
c506f8a 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
Add missing facts
8823e9e 
they are needed since forever. The old rspec just didn't check correctly

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
bump rspec to latest versions
fec53c1 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing inherit from zabbix::params
fe2d062 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing newline
f857c35 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing agent facts to repo_spec
80d922a 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
fix spec tests for repo_spec
d2c3986 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
use getvar() to access in another scope
1d3b746 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in agent_spec
5b23322 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in database_mysql_spec
079d05b 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in database_postgresql_spec
398a78d 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in database_spec
c57886a 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in javagateway_spec
05025bb 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in sender_spec
a52553f 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in server_spec
ff1afbf 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak added 11 commits April 9, 2016 23:01
@bastelfreak
add facts in userparameter_spec
cd1d3eb 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in userparameters_spec
703dff3 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in proxy_spec
82e6d1a 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing param in proxy_spec
7293009 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
remove empty lines (rubocop complains)
a52f58f 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
add missing facts in web_spec
3e68e01 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
switch from gem provider to puppet_gem
702524f 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
remove empty line
a4059ed 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
differ between puppet3/4 on test
a177954 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
Don't check on gem provider on puppet4
fed0c45 
this is currently broken, see
rodjek/rspec-puppet#352

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
disable the broken check on pupet4
f0a2871 
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@dj-wasabi
Copy link

Hi,

From what I can see this looks very good. @ericsysmin do you want to verify this too before we merge?

@dj-wasabi dj-wasabi merged commit d3dbe7f into voxpupuli:master Apr 11, 2016
@dj-wasabi
Copy link

Thanks!!!

@bastelfreak bastelfreak deleted the update-rspec branch April 11, 2016 19:27
@dj-wasabi
Copy link

@bastelfreak

If you think that updating the '.rubocop.yml' would increase the performance/reliability/maintenance/or ... please be my guest. If you do create new pr for this, I'll wait with creating a new release.

@ariacomputer ariacomputer mentioned this pull request Aug 29, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @dj-wasabi @vide