Add require_verify option to install.pp
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 25, 2022
| onlyif => "rpm -q '${name}'", | ||
| unless => "rpm -V '${name}'", | ||
| timeout => $timeout, | ||
| before => Exec["yum-install-${name}"], |
There was a problem hiding this comment.
does that make sense? Do we want to run yum install after we did zum reinsstall?
There was a problem hiding this comment.
In theory, the yum install should detect the rpm is loaded (via the rpm -q check (https://github.com/voxpupuli/puppet-yum/blob/master/manifests/install.pp#L30) and just skip it. If these package isn't installed, the verify check will be skipped but the package will be loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add the option to reinstall a package if the rpm verify fails for the installed package.
This Pull Request (PR) fixes the following issues
None