Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove support for apache_exporter < 1.0.0 #826

Merged
merged 1 commit into from
Dec 30, 2024
Merged

remove support for apache_exporter < 1.0.0 #826

merged 1 commit into from
Dec 30, 2024

Conversation

TheMeier
Copy link
Contributor

fixes #784

bastelfreak
bastelfreak approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to make a minor release first before merging this?

@TheMeier TheMeier added this to the v16.0.0 milestone Dec 30, 2024
@TheMeier
Copy link
Contributor Author

Does it make sense to make a minor release first before merging this?

There are already 2 breaking changes merged in master. See https://github.com/voxpupuli/puppet-prometheus/pulls?q=is%3Apr+milestone%3Av16.0.0+label%3Abackwards-incompatible+is%3Aclosed

@TheMeier TheMeier merged commit 180eca2 into master Dec 30, 2024
28 checks passed
@TheMeier TheMeier deleted the issues/784 branch December 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
v16.0.0
Development

Successfully merging this pull request may close these issues.

Drop suppoprt for apache_exporter < 1.x
2 participants
@TheMeier @bastelfreak