Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppetlabs/stdlib: Require 9.x #665

Merged
merged 6 commits into from
Jun 26, 2023
Merged

puppetlabs/stdlib: Require 9.x #665

merged 6 commits into from
Jun 26, 2023

Conversation

hashworks
Copy link
Member

No description provided.

@hashworks hashworks force-pushed the stdlib9 branch 5 times, most recently from 0838eeb to 4628ab9 Compare June 5, 2023 09:22
@marszip
Copy link
Contributor

marszip commented Jun 14, 2023

There is also a legacy function still in the config.pp:

  errors:
    Evaluation Error: Unknown function: 'has_key'.
      file: modules/prometheus/manifests/config.pp
      line: 262
      column: 9
      factsets: RHEL8

@smortex
Copy link
Member

smortex commented Jun 15, 2023

@hashworks do you want to rebase this on top of #668 and address the issue raised by @marszip? This should fix CI :-)

@smortex
Copy link
Member

smortex commented Jun 16, 2023

The validate_* functions where made useless with datatypes introduced with Puppet 4. $foo =~ Boolean can be used when the datatype cannot be enforced directly at class parameters.

The dependency on postfix should be fixed by this PR when a new release include it:
voxpupuli/puppet-postfix#357

@bastelfreak
Copy link
Member

also contains #670

@bastelfreak
Copy link
Member

released voxpupuli/puppet-postfix#359

@bastelfreak
Copy link
Member

bastelfreak commented Jun 26, 2023 •
edited
Loading

needs a new release for https://forge.puppet.com/modules/saz/sudo : saz/puppet-sudo#294

rwaffen
rwaffen reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@rwaffen rwaffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak bastelfreak merged commit 5b56e4d into master Jun 26, 2023
@bastelfreak bastelfreak deleted the stdlib9 branch June 26, 2023 11:38
@bastelfreak bastelfreak mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen left review comments

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hashworks @marszip @smortex @bastelfreak @rwaffen