Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt web.config.file option for node_exporter versions higher than 1.5.0 #644

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Adapt web.config.file option for node_exporter versions higher than 1.5.0 #644

merged 1 commit into from
Jan 25, 2023

Conversation

Pigueiras
Copy link
Contributor

From: https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md version 1.5.0:

NOTE: A command line arg has been changed from --web.config to --web.config.file.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@Pigueiras Pigueiras changed the title Adapt web.config option for node_exporter versions higher than 1.5.0 Adapt web.config.file option for node_exporter versions higher than 1.5.0 Jan 19, 2023
@Pigueiras Pigueiras force-pushed the fix_webconfig branch 2 times, most recently from 911244d to af16f73 Compare January 19, 2023 15:27
@Pigueiras
Copy link
Contributor Author

The failed checks don't look like because of the change 🤔

@danifr danifr requested a review from rwaffen January 24, 2023 12:33
@bastelfreak
Copy link
Member

Hi,
thanks for the PR! Please rebase after #639 got merged. That will fix the CentOS CI problems.

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 25, 2023
@bastelfreak
Copy link
Member

@Pigueiras please do an actual rebase to get rid of the merge commit. That creates a cleaner git history.

@Pigueiras
Adapt web.config.file option for node_exporter versions higher than 1…
5ca1475 
….5.0

From: https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md
version 1.5.0:

```
NOTE: A command line arg has been changed from --web.config to --web.config.file.
```
@Pigueiras
Copy link
Contributor Author

@Pigueiras please do an actual rebase to get rid of the merge commit. That creates a cleaner git history.

My fault for trusting the sync fork button in Github 😄. It should be fine now in that regard

@bastelfreak bastelfreak merged commit 1fb07b7 into voxpupuli:master Jan 25, 2023
@Pigueiras Pigueiras deleted the fix_webconfig branch January 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@rwaffen rwaffen Awaiting requested review from rwaffen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pigueiras @bastelfreak