Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web-config.yml handling #622

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Implement web-config.yml handling #622

merged 1 commit into from
Jun 3, 2022

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Jun 1, 2022

Pull Request (PR) description

Implement web-config.yml handling

  • needed for native tls without proxy
  • needed for http2 settings
  • needed for basic auth
  • FYI: feature is marked as experimental in prometheus node exporter
  • tested on local systems, spec/unit test still might fail, will fix them than

This Pull Request (PR) fixes the following issues

Fixes #520

@rwaffen rwaffen requested a review from bastelfreak June 1, 2022 08:37
@bastelfreak bastelfreak added enhancement New feature or request tests-fail labels Jun 1, 2022
@rwaffen rwaffen removed the tests-fail label Jun 1, 2022
- needed for native tls without proxy
- needed for http2 settings
- needed for basic auth
- feature is marked as experimental in prometheus node exporter
@rwaffen rwaffen changed the title WIP: Implement web-config.yml handling Implement web-config.yml handling Jun 1, 2022
@bastelfreak bastelfreak merged commit 9581d86 into voxpupuli:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for node exporter 1.x
2 participants