make process exporter service name propagate correctly #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most (but not all!) of the other exporters set the service name properly by passing it like that to the prometheus::daemon. It's important to have this so that it works when installing from Debian packages, where the service name is `prometheus-process-exporter` and not `process-exporter`. This is similar to commit 14849dd ("have a $service_name parameter for all prometheus-exporters") and 82cc646 ("make apache exporter service name customizable").
kenyon
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most (but not all!) of the other exporters set the service name properly by passing it like that to the prometheus::daemon. It's important to have this so that it works when installing from Debian packages, where the service name is
prometheus-process-exporterand notprocess-exporter.This is similar to commit 14849dd ("have a $service_name parameter for all prometheus-exporters", #430 ) and 82cc646 ("make apache exporter service name customizable", #400).