Add php-fpm exporter #605
Merged
Add php-fpm exporter #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e25352 to
f30cf4f
Compare
|
Puppet 6 Tests on Ubuntu 16.04 and 18.04 are failing because of voxpupuli/beaker-hostgenerator#244 |
|
I don't know why Archlinux is failing. But it's not related to my changes. |
baurmatt
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
LGTM. Please check the comment I've added.
(I will keep the PR unmerged for now because @kubicgruenfeld and I are colleagues. Please add an additional approve if you think this can be merged :))
| # Not a big fan of copypasting but prometheus::daemon takes for granted | ||
| # a specific path embedded in the prometheus *_exporter tarball, which | ||
| # php-fpm_exporter lacks currently as of version 2.0.4 | ||
| # TODO: patch prometheus::daemon to support custom extract directories |
There was a problem hiding this comment.
Is there an open issue for this? If not, please open one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds the php-fpm exporter from https://github.com/hipages/php-fpm_exporter
This Pull Request (PR) fixes the following issues
n/a