Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPMI exporter sudo config, add dependency on saz/sudo #565

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

treydock
Copy link

Pull Request (PR) description

The sudo config that was in previous code isn't actually valid and this module was just deploying a file with no validation. I added a dependency on saz/sudo so that proper sudo validation can be performed to avoid deploying broken configuration files. I opted to make it a soft dependency so not added to metadata.json.

@treydock treydock force-pushed the fix-ipmi-sudo branch 2 times, most recently from d62614c to 619587c Compare June 24, 2021 17:42
@ghoneycutt
Copy link
Member

Seems to be some issues with the tests that need resolved though I'm +1 for this approach.

@ghoneycutt
Copy link
Member

saz/puppet-sudo#263

@ghoneycutt
Copy link
Member

If this works with adding the --ignore-dependencies when installing the sudo module and contains a link/comment, that's good with me to move this along without waiting on saz.

@treydock
Copy link
Author

I updated to use --ignore-dependencies and added a comment pointed at merged but not released pull request to bump stdlib dependency range in the saz/sudo module.

@treydock
Copy link
Author

The tests are now failing for postfix exporter, looks like installing one module with --ignore-dependencies breaks future module installs even if that new module you are installing is fine. For now I've just pinned the sudo module to older version that doesn't have max stdlib constraint.

Failure/Error: install_module_from_forge('camptocamp/postfix', '>= 1.8.0 < 2.0.0')
     Beaker::Host::CommandFailure:
       Host 'centos8-64.example.com' exited with 1 running:
        puppet module install camptocamp-postfix -v 1.12.0
       Last 10 lines of output were:
       	Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
       	Notice: Downloading from https://forgeapi.puppet.com ...
       	Error: Could not install module 'camptocamp-postfix' (v1.12.0)
       	  The requested version cannot satisfy one or more of the following installed modules:
       	    puppetlabs-stdlib, installed: 7.1.0, expected: >=4.13.0 < 8.0.0
       	
       	  Use `puppet module install 'camptocamp-postfix' --ignore-dependencies` to install only this module

@treydock
Copy link
Author

That appears to have fixed the tests

@ghoneycutt ghoneycutt merged commit a0d1c2e into voxpupuli:master Jun 24, 2021
@treydock treydock deleted the fix-ipmi-sudo branch June 24, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants