puppetdb_exporter: Update 1.0.0->1.1.0 #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should wait for 1.1.1 camptocamp/prometheus-puppetdb-exporter#9 |
|
upstream fixed it 👍 |
alexjfisher
reviewed
Dec 3, 2020
alexjfisher
reviewed
Dec 3, 2020
| @@ -55,7 +55,7 @@ | |||
| String[1] $package_ensure = 'present', | |||
| String[1] $package_name = 'puppetdb_exporter', | |||
| String[1] $user = 'puppetdb-exporter', | |||
| String[1] $version = '1.0.0', | |||
| String[1] $version = '1.1.0', | |||
There was a problem hiding this comment.
I think changing the default version installed is a breaking change? Perhaps a several default exporter versions could be batched into a single release?
There was a problem hiding this comment.
yes breaking change. But I would like to update the other exporters on individual PRs (and we already have a few other backwards-incompatible changes on master)
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Jan 21, 2021
puppetdb_exporter: Update 1.0.0->1.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues