Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon: create env files only if required #493

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Daemon: create env files only if required #493

merged 1 commit into from
Sep 26, 2020

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Sep 26, 2020

In the past we always created the env files, even if they are empty if $env_vars isn't set). The env_file_path was optional, but we set a default via hiera which makes it impossible to overwrite. So the Optioanl[] is useless and can be removed. Also It's always an absolute path so we can replace String with Stdlib::Absolutepath.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 26, 2020
@bastelfreak bastelfreak self-assigned this Sep 26, 2020
@igalic
Copy link

igalic commented Sep 26, 2020

what's up with the failing tests tho?

@bastelfreak
Copy link
Member Author

I will fix the tests later, after #496 got merged.

@alexjfisher
Copy link
Member

I vaguely recall somebody wanting the env var files in exporters that didn't take environment variables as a hack for something else. Can't really remember the details. I think #303 was the PR with the discussion, but there's probably more in the IRC logs too.

Maybe it was that native debian packages used /etc/sysconfig files for their init scripts and this module writes those files??

@bastelfreak
Copy link
Member Author

but that should still work, right? I didn't change how the env file is written. It's still an erb template that iterates on a hash to print their key/values.

@alexjfisher
Copy link
Member

but that should still work, right? I didn't change how the env file is written. It's still an erb template that iterates on a hash to print their key/values.

yeah, think you're ok.

@bastelfreak bastelfreak merged commit 6598ab6 into voxpupuli:master Sep 26, 2020
@bastelfreak bastelfreak deleted the env branch September 26, 2020 18:28
@anarcat
Copy link

anarcat commented Feb 22, 2021

I vaguely recall somebody wanting the env var files in exporters that didn't take environment variables as a hack for something else. Can't really remember the details. I think #303 was the PR with the discussion, but there's probably more in the IRC logs too.

Maybe it was that native debian packages used /etc/sysconfig files for their init scripts and this module writes those files??

yeah that was me, and i suspect i'll survive this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants