prometheus: harden systemd service #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
reviewed
Jan 6, 2020
| @@ -16,6 +16,19 @@ ExecStart=/usr/local/bin/prometheus \ | |||
| ExecReload=/bin/kill -HUP $MAINPID | |||
| KillMode=process | |||
There was a problem hiding this comment.
is there any good reason for not setting the KillMode to control-group?
There was a problem hiding this comment.
I'm not sure about it. I didn't touch this options since I don't know yet which value would suit best.
dhollinger
approved these changes
Jan 6, 2020
|
FWIW, i have forwarded this to the debian package as well https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950759 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Jan 21, 2021
prometheus: harden systemd service
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
prometheus: harden systemd service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those hardening options are live in the Arch package since a long time. I use them as well and they work fine. Arch source: https://git.archlinux.org/svntogit/packages.git/tree/trunk/prometheus.service?h=packages/prometheus