Add prom command line args and validation #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hooten, thanks for the PR. Can you take a look at the failing travis tests? |
bastelfreak
reviewed
Oct 19, 2019
bastelfreak
reviewed
Oct 19, 2019
|
Thanks for the commends @bastelfreak. This PR is still a WIP. I'm having trouble reproducing the failing tests locally. I will work on it more this week |
|
Hey @bastelfreak, I made the changes you suggested and fixed the tests. When you get a chance, I'd really appreciate another review. Thanks! |
|
Thanks for the work! |
|
Thanks! I'm happy to contribute! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Jan 21, 2021
Add prom command line args and validation
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add prom command line args and validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request adds the remaining command-line arguments available to Prometheus v2 (and a few for v1). It also adds validation that will fail the puppet run if arguments are used incorrectly. It continues to expose the
extra_optionsparameter for custom command-line logic. It also adds a number of tests for using command line arguments.Although it was possible to specify arbitrary command-line arguments previously using
extra_options, this PR makes CLI args more discoverable and manages better.This Pull Request (PR) fixes the following issues
Fixes #52