Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphite_exporter: update 0.2.0->0.7.1 #357

Merged
merged 1 commit into from
May 23, 2020
Merged

graphite_exporter: update 0.2.0->0.7.1 #357

merged 1 commit into from
May 23, 2020

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak self-assigned this Jul 19, 2019
@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@dhoppe
Copy link
Member

dhoppe commented May 22, 2020

Basically this pull request works, but you should increase the version of graphite_exporter to 0.7.1.

@ghoneycutt
Copy link
Member

@dhoppe From your comment It is not clear if this is ready for merge. Does it need a change made for 0.7.1 beforehand? If so, could you add it to this PR?

ghoneycutt
ghoneycutt requested changes May 23, 2020
View reviewed changes
Copy link
Member

@ghoneycutt ghoneycutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acceptance testing should validate version

@bastelfreak bastelfreak changed the title graphite_exporter: update 0.2.0->0.6.2 graphite_exporter: update 0.2.0->0.7.1 May 23, 2020
@bastelfreak
Copy link
Member Author

we already have tests inplace that ensure the module workflow works as expected. I don't think that a test is required to explicitly validate the version. I'm already busy enough updating the exporter versions. Feel free to submit patches if you like to see such tests in our acceptance test suite.

@dhoppe dhoppe merged commit 9ac8020 into voxpupuli:master May 23, 2020
@bastelfreak bastelfreak deleted the updates21 branch May 23, 2020 10:23
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
@dhoppe
Merge pull request voxpupuli#357 from bastelfreak/updates21
e0c4a78 
graphite_exporter: update 0.2.0->0.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoppe dhoppe dhoppe approved these changes

@ghoneycutt ghoneycutt ghoneycutt requested changes

@foxxx0 foxxx0 foxxx0 approved these changes

Assignees

@bastelfreak bastelfreak

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastelfreak @dhoppe @ghoneycutt @foxxx0