-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
180 rule files param #241
180 rule files param #241
Conversation
…g a list of rule files from data in prometheus::alerts and prometheus::extra_alerts
…metheus1 and 2 . I am not sure if prometheus1 is even covered, and confused that what looks like variable interpolation is going right through to File[/etc/prometheus/prometheus.yaml] as literal
I think I have mistaken what belongs in the prometheus.yaml fixtures. Does this get expanded with defaults? I suspect not. |
@bramblek1 the fixtures represent an actual config from a running system. Puppet won't expand any variables in it. |
Thanks @bastelfreak - I think I have run across a different issue.
Since this error seems to come from promtool check , that string must be ending up in prometheus.yaml as a literal, which is what confused me previously. This seems to be coming from the module hiera data/defaults.yaml - where prometheus::rule_files is using puppet DSL type syntax, not hiera lookup.
Since server.pp is handling the addition of alert.rules if |
…me in prometheus::rule_files
thanks for fixing this @bramblek1 ! |
Thank you so much @bramblek1! |
180 rule files param
180 rule files param
Pull Request (PR) description
Fixes an issue where
prometheus::rule_files
param was never used to populate configuration as it was not included when combiningextra_alerts
andalerts
params.This Pull Request (PR) fixes the following issues
Fixes #180