Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow scrap options by file #18

Closed
wants to merge 3 commits into from
Closed

Feature/allow scrap options by file #18

wants to merge 3 commits into from

Conversation

Cosaquee
Copy link

@Cosaquee Cosaquee commented Oct 5, 2016

Here is my proposition for custom config:

  • if we want to setup Prometheus with custom config we can use custom_config parameter that accepts string
  • if custom_config is set Puppet will create prometheus.yml with content of custom_config
  • if custom_config is not set it will use basic flow to create prometheus.yml

Copy link
Collaborator

@brutus333 brutus333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the code to avoid issues with: #25

@brutus333
Copy link
Collaborator

I'm moving this repo to voxpopuli: https://github.com/voxpupuli/puppet-prometheus.
Please re-open the PR there when ready.

@brutus333 brutus333 closed this Dec 27, 2016
roidelapluie pushed a commit that referenced this pull request Jun 21, 2017
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants