Fix v1 logging

voxpupuli · Oct 23, 2019 · 8d2060f · 8d2060f
1 parent 284f1a9
commit 8d2060f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/manifests/config.pp b/manifests/config.pp
@@ -33,7 +33,8 @@
         'rules.alert.for-outage-tolerance'        => $prometheus::alert_for_outage_tolerance,
         'rules.alert.for-grace-period'            => $prometheus::alert_for_grace_period,
         'rules.alert.resend-delay'                => $prometheus::alert_resend_delay,
-        'query.lookback-delta'                    => $prometheus::query_lookback_delta
+        'query.lookback-delta'                    => $prometheus::query_lookback_delta,
+        'log.format'                              => $prometheus::log_format,
       }
     }
 
@@ -129,7 +130,7 @@
         'query.max-concurrency'                    => $prometheus::query_max_concurrency,
         'query.staleness-delta'                    => $prometheus::query_staleness_delta,
         'log.level'                                => $prometheus::log_level,
-        'log.format'                               => "\"logger:stdout${v1_log_format}\""
+        'log.format'                               => 'logger:stdout',
       }
     }
 

diff --git a/spec/classes/prometheus_spec.rb b/spec/classes/prometheus_spec.rb
@@ -480,8 +480,7 @@
                 query_timeout: '2m',
                 query_max_concurrency: '30',
                 query_staleness_delta: '5m',
-                log_level: 'fatal',
-                log_format: 'json'
+                log_level: 'fatal'
               }
             end
 

diff --git a/spec/fixtures/files/cli/prometheus1_all.systemd b/spec/fixtures/files/cli/prometheus1_all.systemd
@@ -28,7 +28,7 @@ ExecStart=/usr/local/bin/prometheus \
   -query.max-concurrency=30 \
   -query.staleness-delta=5m \
   -log.level=fatal \
-  -log.format="logger:stdout?json=true"
+  -log.format=logger:stdout
 ExecReload=/bin/kill -HUP $MAINPID
 KillMode=process
 Restart=always

diff --git a/spec/fixtures/files/cli/prometheus1_extra.systemd b/spec/fixtures/files/cli/prometheus1_extra.systemd
@@ -13,7 +13,7 @@ ExecStart=/usr/local/bin/prometheus \
   -web.console.libraries=/usr/local/share/prometheus/console_libraries \
   -storage.local.path=/var/lib/prometheus \
   -storage.local.retention=360h \
-  -log.format="logger:stdout" \
+  -log.format=logger:stdout \
   -web.telemetry-path=/metrics
 ExecReload=/bin/kill -HUP $MAINPID
 KillMode=process