Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0 #1496

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Release 4.0.0 #1496

merged 1 commit into from
Aug 25, 2022

Conversation

root-expert
Copy link
Member

If there is any other breaking change pending I can hold it, let me know

Closes #1495

@smortex
Copy link
Member

smortex commented Aug 24, 2022

o/ @root-expert I fixed CI and opened a few more backwards-incompatble PR which are being reviewed. When done, I would be pleased to do another major release 😎

If you have some time, can you review these PR? Also, no objection that I borrow your PR to update it? 😁

@root-expert
Copy link
Member Author

root-expert commented Aug 24, 2022

\o @smortex

Feel free to force-push to this PR as I'm currently on vacation and I don't really have access to my PC 😄

EDIT: Github doesn't let me approve my own PR xD

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I can approve my commit since I did not opened this PR. So let me do this for you 😉

I'll steal leave other people approve / raise concerns before merging and releasing a new version!

/me is impatient to update the module in production at $WORK!

@smortex smortex merged commit acb3050 into master Aug 25, 2022
@smortex smortex deleted the rel400 branch August 25, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Release / Puppet Forge Release (Question)
3 participants