Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSpec/RepeatedDescription #18

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix RSpec/RepeatedDescription #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/beaker_puppet_helpers/dsl_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def logger
expect(result).to be_an(Array)
end

it 'operates on an array of hosts' do
it 'operates on an array of hosts in parallel' do
InParallel::InParallelExecutor.logger = dsl.logger
# This will only get hit if forking processes is supported and at least 2 items are being submitted to run in parallel
# expect( InParallel::InParallelExecutor ).to receive(:_execute_in_parallel).with(any_args).and_call_original.exactly(2).times
Expand Down Expand Up @@ -122,13 +122,13 @@ def logger
dsl.apply_manifest_on(agent, 'class { "boo": }', expect_failures: true)
end

it 'enforces exit codes through :expect_failures' do
it 'enforces exit codes through :expect_failures and catch_failures' do
expect do
dsl.apply_manifest_on(agent, 'class { "boo": }', expect_failures: true, catch_failures: true)
end.to raise_error(ArgumentError, /catch_failures.+expect_failures/)
end

it 'enforces added exit codes through :expect_failures' do
it 'enforces merges exit codes from :expect_failures and acceptable_exit_codes' do
expect(dsl).to receive(:create_remote_file).and_return(true)
expect(Beaker::PuppetCommand).to receive(:new).and_return('puppet_command')

Expand Down