Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a host_packages method from validate_host #1729

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 27, 2022

This separates the logic of getting a list of packages into a separate method. The main motivation for this is that beaker-docker has duplicated the case statement. By providing this method, that reuse it and there's a single place to define this.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1729 (ace09dd) into master (cdc17d9) will increase coverage by 0.02%.
The diff coverage is 57.14%.

❗ Current head ace09dd differs from pull request most recent head 252f57e. Consider uploading reports for the commit 252f57e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   74.76%   74.78%   +0.02%     
==========================================
  Files          82       82              
  Lines        4846     4851       +5     
==========================================
+ Hits         3623     3628       +5     
  Misses       1223     1223              
Impacted Files Coverage Δ
lib/beaker/host_prebuilt_steps.rb 73.75% <57.14%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc17d9...252f57e. Read the comment docs.

@ekohl ekohl force-pushed the extract-package-method-v2 branch from aabef2c to b3c63d8 Compare January 27, 2022 16:01
This separates the logic of getting a list of packages into a separate
method. The main motivation for this is that beaker-docker has
duplicated the case statement. By providing this method, that reuse it
and there's a single place to define this.
@ekohl ekohl force-pushed the extract-package-method-v2 branch from b3c63d8 to 252f57e Compare January 27, 2022 16:02
@bastelfreak bastelfreak merged commit 65b9e35 into voxpupuli:master Jan 27, 2022
@ekohl ekohl deleted the extract-package-method-v2 branch January 27, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants