(BKR-1094) Deprecate vcloud's silent fallback to vmpooler #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates an historical convenience option to allow vmpooler hosts to be accessed transparently using vcloud.
|
Per discussion, this is "Do Not Merge" pending change to notify of deprecation (and continue old functionality of loading vmpooler) when option |
|
Jenkins, retest this please. |
1 similar comment
|
Jenkins, retest this please. |
kevpl
previously requested changes
Jun 20, 2018
lib/beaker/hypervisor/vcloud.rb
Outdated
| Beaker::Vmpooler.new(vcloud_hosts, options) | ||
| else | ||
| super | ||
| end | ||
| end | ||
|
|
||
|
|
| allow_any_instance_of( Beaker::Vmpooler ).to \ | ||
| receive(:load_credentials).and_return(fog_file_contents) | ||
| expect( opts[:logger] ).to receive(:warn).once | ||
| Beaker::Vcloud.new( make_hosts, opts) |
There was a problem hiding this comment.
please pick a consistent spacing style for this PR and spread it out for the entire PR. In this test method I'm seeing these different styles, sometimes on the same line:
method( option )
method(option)
method( option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates an historical convenience option to allow vmpooler hosts to be accessed transparently using vcloud.