apply best-practices to GitHub workflow #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 17, 2023
There was a problem hiding this comment.
This repo has required checks. Should we copy the pattern we have in gha-puppet where we have a dummy test at the end that needs rspec, which we can set as required? Then we can easily drop individual versions without changing the required checks all the time?
|
@ekohl done. After we merge this we can mark the new job as required. |
ekohl
reviewed
Mar 17, 2023
ekohl
requested changes
Mar 19, 2023
|
@ekohl please take a look again, should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also contains #55