Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Upgrade acceptance tests and docs #15

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Conversation

Dakta
Copy link
Contributor

@Dakta Dakta commented Jul 10, 2018

Puppet Labs Vagrant Boxes (https://vagrantcloud.com/puppetlabs/) are unsupported and badly outdated. Due to CentOS lack of TLSv1.2 support, they're also broken for acceptance testing. Since we don't need a Puppet environment preconfigured, I've updated the acceptance nodes to use the official CentOS 7 Vagrant Box. All tests pass.

Puppet Labs Vagrant Boxes (https://vagrantcloud.com/puppetlabs/) are unsupported and badly outdated. For Beaker acceptance testing, we don't need a Puppet environment preconfigured so I've updated the acceptance nodes to use the official CentOS 7 Vagrant Box.
@Dakta Dakta requested a review from kevpl July 10, 2018 22:27
Copy link
Contributor

@kevpl kevpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

abstraction on top of a VM or cloud provider that allows you to manage
hosts and their provisioning. [Their Site](https://www.vagrantup.com/).
hosts and their provisioning. <https://www.vagrantup.com/>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked! 🚀

@kevpl kevpl merged commit 498a601 into voxpupuli:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants