-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Hiera 5 #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magyargergo
approved these changes
Apr 17, 2023
magyargergo
suggested changes
Apr 17, 2023
Merged
ekohl
force-pushed
the
convert-to-hiera-5
branch
from
November 3, 2023 16:43
3d3c60c
to
647b1a0
Compare
Testing in theforeman/puppet-pulpcore#312 |
bastelfreak
approved these changes
Nov 3, 2023
ekohl
force-pushed
the
convert-to-hiera-5
branch
2 times, most recently
from
November 3, 2023 17:18
5091231
to
dc1344e
Compare
bastelfreak
reviewed
Nov 3, 2023
ekohl
force-pushed
the
convert-to-hiera-5
branch
from
November 3, 2023 17:21
dc1344e
to
e918969
Compare
bastelfreak
approved these changes
Nov 3, 2023
ekohl
force-pushed
the
convert-to-hiera-5
branch
from
November 3, 2023 18:01
e918969
to
7523d28
Compare
Until now the deprecated Hiera 3 config was deprecated. This rewrites it to only generate Hiera 5 version.
ekohl
force-pushed
the
convert-to-hiera-5
branch
from
November 3, 2023 18:04
7523d28
to
4eccbe1
Compare
Now I think it's ready. Tested it out locally and now I feel confident this is good. |
bastelfreak
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the deprecated Hiera 3 config was deprecated. This rewrites it to only generate Hiera 5 version.