Initial implementation of hypervisor #10 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offers limited options to customize server creation (choosing an image, server type and location by name). SSH keys are being generated on-the-fly building on the `ssh_data` gem.
Codecov ReportBase: 0.00% // Head: 92.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
===========================================
+ Coverage 0.00% 92.30% +92.30%
===========================================
Files 2 3 +1
Lines 26 78 +52
===========================================
+ Hits 0 72 +72
+ Misses 26 6 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bastelfreak
reviewed
Nov 21, 2022
README.md
Outdated
| You need to create an API token using Hetzner's cloud console. Make | ||
| sure to create the token in the correct project. | ||
|
|
||
| `beaker-hcloud` expects the token to be in the `HCLOUD_TOKEN` |
There was a problem hiding this comment.
@ekohl when we introduce a new environment variable, do we want it prefixed with BEAKER_?
There was a problem hiding this comment.
Sorry for the delay, but I finally got around to renaming the environment variable.
bastelfreak
reviewed
Nov 21, 2022
| s.add_runtime_dependency 'hcloud', '>= 1.0.3', '< 2.0.0' | ||
| s.add_runtime_dependency 'ssh_data', '~> 1.3' |
There was a problem hiding this comment.
a bit dissapointing that the ed25519 isn't sufficient here
There was a problem hiding this comment.
Well, the ed25519 gem is only about the algorithm itself. It knows nothing about SSH. The (to me) disappointing bit was that no existing gem seems to support the key generation / serialization of ed25519 keys. net-ssh does not include key generation at all. There is a gem called sshkey which would be perfect but only supports RSA/DSA (with partial support for reading ed25519 keys).
ssh_data was the closest thing I could find for what we need, but it still lacked the serialization of the private key.
|
Sorry for the slow response here, I was busy with other stuff :(.I gave this a try in our puppet-hdm module: This fails because our github action doesn't support a custom image option (yet). This results in the following error: When I pass the image attribute it works and creates a VM:
|
|
Edit: When I don't mix ubuntu 18 and 20 it's actually working: Edit 2: I did some try and error and updated beaker-hostgenerator: voxpupuli/beaker-hostgenerator#261 |
puppet_metadata adds an attribute to each host, with the desired hostname: https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/beaker.rb#L51
configure the hostname with the desired hostname
|
The rubocop action is now failing. Sadly, I cannot reproduce this locally. Also the error message given does not indicate where the problem occurs 🤷♂️ |
|
@oneiros check https://github.com/voxpupuli/beaker-hcloud/pull/11/files. rubocop does annotations and complains in line 93 in file spec/beaker/hypervisor/hcloud_spec.rb. Does that help? |
|
@bastelfreak Thank you so much. That helped! I fixed the problem and rubocop immediately found more ones 🙄 But this finally led me to understand why I could not observe this locally: Since OTOH, this way you always get up-to-date feedback on every CI run. |
|
yes, we need to figure out which rubocop version (and ruby version) we want to use. All other beaker gems suppory Ruby 2.4/2.5 and newer, but we plan to update this in the next weeks. Do you have any idea why Ruby 2.7 fails in CI? |
Not to the point that I can fully explain it, no 😅 But I pushed a fix that seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers limited options to customize server creation (choosing an image, server type and location by name).
SSH keys are being generated on-the-fly building on the
ssh_datagem.See #10 for details.