fix load_evaluation bug with serialized_info

[imanjra]

What changes are proposed in this pull request?

fix load_evaluation bug with serialized_info

How is this patch tested? If it is not, please explain why.

Using model evaluation panel

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• Bug Fixes

  • Improved error reporting for unsupported evaluation types in the Evaluation Panel.

• Chores

  • Adjusted the order of operations in the load_evaluation method for better context in error responses.

[coderabbitai]

Walkthrough

The pull request introduces a minor modification in the load_evaluation method of the EvaluationPanel class. The key change involves repositioning the serialized_info = info.serialize() line before the evaluation type check. This adjustment ensures that serialized information is prepared in advance, enabling more comprehensive error reporting when an unsupported evaluation type is encountered. The core functionality of loading evaluation results and computing metrics remains unchanged.

Changes

File	Change Summary
fiftyone/operators/builtins/panels/model_evaluation/__init__.py	Repositioned serialized_info = info.serialize() before evaluation type check to improve error handling

Possibly related PRs

• fix model evaluation panel name #5090: Modifications to EvaluationPanel class in the same file
• model evaluation bug fixes #5166: Updates to load_pending_evaluations method
• fix pending evaluation also being listed as completed #5194: Introduction of has_evaluation_results method
• Fixing #5254 #5267: Changes to load_evaluation method's error handling

Suggested labels

bug

Suggested reviewers

• manivoxel51

Poem

🐰 A rabbit's tale of code so bright,
Where lines dance left and lines dance right,
Serialized info, now in its place,
Errors caught with newfound grace,
A small shift makes the system shine! 🔍

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

fiftyone/operators/builtins/panels/model_evaluation/__init__.py (1)

311-311: LGTM! Good fix for the error handling.

Moving serialized_info = info.serialize() before the evaluation type check ensures proper error reporting for unsupported evaluation types. This is a clean fix that maintains the error context.

Consider enhancing the error handling further by including the actual evaluation type in the error message:

             if evaluation_type not in SUPPORTED_EVALUATION_TYPES:
                 ctx.panel.set_data(
                     f"evaluation_{computed_eval_key}_error",
-                    {"error": "unsupported", "info": serialized_info},
+                    {
+                        "error": "unsupported",
+                        "info": serialized_info,
+                        "type": evaluation_type,
+                        "supported_types": SUPPORTED_EVALUATION_TYPES
+                    },
                 )
                 return

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4bcc45d and b92e747.

📒 Files selected for processing (1)

• fiftyone/operators/builtins/panels/model_evaluation/__init__.py (1 hunks)