-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify delegated operation doc #5291
Changes from 4 commits
8dfadc2
52e4175
774bd6f
4c5af6c
cd199ad
635f4a8
e2e08d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -889,6 +889,11 @@ def store(self, store_name): | |
dataset_id = self.dataset._doc.id | ||
return ExecutionStore.create(store_name, dataset_id) | ||
|
||
def _get_serialized_request_params(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really liking this as the interface...but didn't feel that changing |
||
request_params_copy = self.request_params.copy() | ||
request_params_copy.pop("panel_state", None) | ||
return request_params_copy | ||
|
||
def serialize(self): | ||
"""Serializes the execution context. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an existing issue that I think might explain some of the weirdness/handling of
op.context
asdict
!Without this change this is a no-op.