Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hover background for panel in add panel popover #5235

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Dec 6, 2024

What changes are proposed in this pull request?

fix hover background for panel in add panel popover to consistent with for all items

How is this patch tested? If it is not, please explain why.

Using the app

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

fix hover background for panel in add panel popover to consistent with for all items

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features

    • Updated layout styles for the AddPanelButton and AddPanelItem components to ensure they occupy the full width of their containers.
    • Modified display behavior for the "NEW" label based on the state of the "BETA" label.
  • Bug Fixes

    • Improved layout consistency by adjusting width properties in relevant components.

@imanjra imanjra requested a review from a team December 6, 2024 19:07
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Walkthrough

The pull request introduces modifications to two components: AddPanelButton and AddPanelItem. In AddPanelButton, the Grid component's sx prop is updated to ensure it occupies the full width of its container. In AddPanelItem, a new style property is added to the Stack component for full width, and the logic for the showNew variable is adjusted based on the state of showBeta. No other functional logic or public entity declarations were altered.

Changes

File Path Change Summary
app/packages/spaces/src/components/AddPanelButton.tsx Updated Grid component's sx prop to sx={{ width: "100%" }} for full-width layout.
app/packages/spaces/src/components/AddPanelItem.tsx Added width: "100%" to Stack component; modified showNew logic based on showBeta.

Possibly related PRs

Suggested reviewers

  • ritch
  • minhtuev

🐰 In the garden where the panels grow,
A button's width now steals the show.
With styles so wide, they dance and play,
Making room for joy in every way!
Hopping along, we cheer and sing,
For changes bright, oh what joy they bring! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
app/packages/spaces/src/components/AddPanelItem.tsx (1)

Line range hint 28-41: Consider enhancing type safety for event handling

While the event handling is robust, consider explicitly typing the event parameter for better type safety.

-      onClick={(e) => {
+      onClick={(e: React.MouseEvent<HTMLDivElement>) => {
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1649f2f and f71b646.

📒 Files selected for processing (2)
  • app/packages/spaces/src/components/AddPanelButton.tsx (1 hunks)
  • app/packages/spaces/src/components/AddPanelItem.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/packages/spaces/src/components/AddPanelButton.tsx
🧰 Additional context used
📓 Path-based instructions (1)
app/packages/spaces/src/components/AddPanelItem.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

🔇 Additional comments (3)
app/packages/spaces/src/components/AddPanelItem.tsx (3)

44-47: LGTM: Styling changes align with PR objectives

The addition of width: "100%" ensures consistent hover behavior across the entire panel item, which directly addresses the PR's goal.


Line range hint 10-17: LGTM: Well-typed React component

The component follows TypeScript best practices with proper prop typing and interface usage.


Line range hint 21-24: Verify the intended behavior of NEW/BETA label precedence

The change ensures that the NEW label is hidden when BETA is shown. While this improves visual clarity, please confirm if this behavior aligns with the intended design.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and works beautifully🥇

@imanjra imanjra merged commit 9fae650 into develop Dec 12, 2024
12 checks passed
@imanjra imanjra deleted the bugfix/panel-name-bg branch December 12, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants