Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: y-axis autorange reversed on all evaluation chart #5193

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

lanzhenw
Copy link
Contributor

@lanzhenw lanzhenw commented Nov 26, 2024

What changes are proposed in this pull request?

fix the bug that evaluation chart y-axis all reversed. Only confusion matrices chart should revert, while others maintain the same.

How is this patch tested? If it is not, please explain why.

Screenshot 2024-11-26 at 9 56 35 AM
Screenshot 2024-11-26 at 9 56 30 AM

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features
    • Enhanced visual representation of confusion matrices with improved layout configurations.
  • Bug Fixes
    • Adjusted y-axis rendering for the evaluation confusion matrix to ensure correct alignment of true labels.
    • Updated y-axis behavior in the evaluation plot for improved clarity.

@lanzhenw lanzhenw requested a review from brimoor November 26, 2024 16:01
@lanzhenw lanzhenw self-assigned this Nov 26, 2024
Copy link
Contributor

coderabbitai bot commented Nov 26, 2024

Walkthrough

The changes in this pull request involve modifications to the layout configurations of confusion matrix visualizations in two components: Evaluation.tsx and EvaluationPlot.tsx. Specifically, Evaluation.tsx introduces a reversed autorange for the y-axis in the confusion matrix, while EvaluationPlot.tsx removes this reversed setting. No other logic, state management, or data handling within these components has been altered.

Changes

File Change Summary
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx Added layout property with yaxis: { autorange: "reversed" } for confusion matrix visualization.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/EvaluationPlot.tsx Removed autorange: "reversed" from yaxis configuration in layoutDefaults.

Possibly related PRs

Suggested reviewers

  • brimoor

🐰 In the land of plots and charts so bright,
Confusion matrices dance in the light.
With y-axes reversed, they show their true face,
A clearer view in this data race.
So hop along, let the visuals play,
In the world of numbers, we find our way! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d12edd6 and f421f78.

📒 Files selected for processing (1)
  • app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/EvaluationPlot.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/EvaluationPlot.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanzhenw the axes are now oriented properly, but the y-axis labels are now slightly clipped for all screen widths, which I don't think was the case previously.

Maybe the way you implemented this might be overriding other default yaxis layout options?

Screenshot 2024-11-26 at 11 15 32 AM Screenshot 2024-11-26 at 11 15 22 AM

@lanzhenw lanzhenw requested a review from brimoor November 26, 2024 16:35
@brimoor brimoor requested a review from imanjra November 26, 2024 16:42
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionally LGTM now, but would prefer that @imanjra also approve from a code standpoint before merging

Copy link
Contributor

@imanjra imanjra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants