-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #5078
fix typo #5078
Conversation
WalkthroughThe changes in this pull request involve a modification to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/packages/operators/src/CustomPanel.tsx (1)
Line range hint
139-147
: Consider standardizing all parameter names to camelCase.While this change fixes one parameter, other parameters in the
defineCustomPanel
function still use snake_case (e.g.,on_change_ctx
,on_change_view
, etc.). Consider updating all parameters to follow the same camelCase convention for consistency.Here's the suggested naming convention for all parameters:
export function defineCustomPanel({ - on_load, - on_change, - on_unload, - on_change_ctx, - on_change_view, - on_change_dataset, - on_change_current_sample, - on_change_selected, - on_change_selected_labels, - on_change_extended_selection, - on_change_group_slice, - on_change_query_performance, - on_change_spaces, - panel_name, - panel_label, + onLoad, + onChange, + onUnload, + onChangeCtx, + onChangeView, + onChangeDataset, + onChangeCurrentSample, + onChangeSelected, + onChangeSelectedLabels, + onChangeExtendedSelection, + onChangeGroupSlice, + onChangeQueryPerformance, + onChangeSpaces, + panelName, + panelLabel, })
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/packages/operators/src/CustomPanel.tsx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/packages/operators/src/CustomPanel.tsx (1)
Pattern **/*.{ts,tsx}
: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🔇 Additional comments (1)
app/packages/operators/src/CustomPanel.tsx (1)
143-143
: LGTM! Parameter name now follows React/TypeScript conventions.
The change from on_change_query_performance
to onChangeQueryPerformance
correctly aligns with React and TypeScript naming conventions where camelCase is preferred for properties and parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
What changes are proposed in this pull request?
typo
Summary by CodeRabbit
CustomPanel
component, enhancing readability without changing functionality.