-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix teams install command #5024
Conversation
WalkthroughThe pull request updates the documentation for the FiftyOne Teams installation process, specifically for the Python SDK. It modifies the installation command syntax for environment variables, clarifies the module structure, and expands instructions for using Poetry. Additionally, it details cloud credential configuration for various providers and introduces a section on managing these credentials through the Teams UI. Overall, the changes aim to enhance clarity and usability for users setting up and configuring the FiftyOne Teams environment. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
docs/source/teams/installation.rst (1)
Line range hint
1-24
: Consider adding a troubleshooting sectionSince the installation command has been problematic, it would be helpful to add a "Troubleshooting" section that covers:
- Common installation issues and their solutions
- How to verify successful installation
- What to do if the TOKEN is invalid or expired
- Steps to upgrade from a broken installation
This would help users diagnose and resolve installation problems more efficiently.
Would you like me to help draft content for a troubleshooting section?
@@ -46,7 +46,7 @@ private PyPI server as shown below: | |||
|
|||
.. code-block:: shell | |||
|
|||
pip install --index-url https://{$TOKEN}@pypi.fiftyone.ai fiftyone | |||
pip install --index-url https://${TOKEN}@pypi.fiftyone.ai fiftyone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct fix for the shell variable syntax!
The change from {$TOKEN}
to ${TOKEN}
fixes the installation command by using the proper shell variable expansion syntax. This explains why the teams install command was broken, as the previous syntax would not correctly expand the TOKEN environment variable.
What changes are proposed in this pull request?
Well... that's been broken for a while and definitely doesn't work...
Summary by CodeRabbit