skip e2e tests that use zoo datasets

[sashankaryal]

Because of google drive's rate limiting, zoo datasets are having a problem being downloaded. #4802 adds caching for zoo datasets and models, but until that PR is undrafted and stable, we'll just skip these tests so as to not block PRs.

Summary by CodeRabbit

• Bug Fixes
  • Skipped several tests across different functionalities due to reliance on an unavailable zoo dataset, ensuring that test execution flow remains stable while addressing dataset issues.
  • Tests affected include those for color scheme, display options, sidebar functionality, quickstart groups, and tagging features.

[coderabbitai]

Walkthrough

The changes involve the addition of skip directives in multiple test suites across various files, specifically indicating that certain tests will not be executed due to their reliance on a dataset referred to as the "Zoo Dataset." This modification affects the control flow of the test execution, temporarily disabling specific tests until the dataset issues are resolved.

Changes

File Path	Change Summary
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts, e2e-pw/src/oss/specs/display-options/display-options.spec.ts, e2e-pw/src/oss/specs/sidebar/sidebar-cifar.spec.ts, e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts, e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts, e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts, e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts	Added test.skip(true, "THIS TEST USES ZOO DATASET. TODO: FIX IT"); to skip tests relying on the Zoo Dataset.

Possibly related PRs

• fix tagger e2e tests #4783: The changes in this PR involve modifications to the tagger.spec.ts test suite, which also includes a skip directive for tests related to the "Zoo Dataset." This indicates a direct connection to the main PR's focus on skipping tests due to dataset availability issues.

🐰 In the land of code where tests do play,
A dataset's absence led to a delay.
With skips in place, we pause and reflect,
Until the Zoo's data is ready to perfect.
Hopping along, we'll fix it soon,
For tests will run under the bright coding moon! 🌙

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts (1)

36-36: Skipping the test is acceptable temporarily, but ensure there is a plan to fix it.

Skipping tests reduces the test coverage and may lead to undetected issues. However, temporarily skipping a failing test to unblock other work is acceptable.

Please create a GitHub issue to track the work required to fix this test. Do you want me to open a GitHub issue for this?

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 71e926a and d736807.

Files selected for processing (7)

• e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/display-options/display-options.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/sidebar/sidebar-cifar.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts (1 hunks)
• e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts (1 hunks)

Files skipped from review due to trivial changes (5)

• e2e-pw/src/oss/specs/display-options/display-options.spec.ts
• e2e-pw/src/oss/specs/sidebar/sidebar-cifar.spec.ts
• e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts
• e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts
• e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts

Additional context used

Path-based instructions (2)

e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

Additional comments not posted (1)

e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts (1)

26-27: LGTM!

The code change aligns with the PR objective of skipping e2e tests that use zoo datasets. Using test.skip() with a TODO comment is a valid way to temporarily disable the test case until it is fixed.