-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update YOLOv5DatasetImporter
to support loading list of .txt
#4742
Conversation
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
YOLOv5DatasetImporter
to support list of txt
YOLOv5DatasetImporter
to support list of txtYOLOv5DatasetImporter
to support loading list of .txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
FYI we already have tests that cover quite a few aspects of YOLOv5 import/export here: fiftyone/tests/unittests/import_export_tests.py Line 1646 in e8ec301
|
You're welcome. You guys built such a great library. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4742 +/- ##
===========================================
- Coverage 99.27% 99.12% -0.16%
===========================================
Files 47 49 +2
Lines 16212 16642 +430
===========================================
+ Hits 16095 16496 +401
- Misses 117 146 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cherry-picking #4742 for release
What changes are proposed in this pull request?
Currently, the
YOLOv5DatasetImporter
does not support loading a split contains list of.txt
, e.g.:And, I make it support.
How is this patch tested? If it is not, please explain why.
I have tested the following variants of YOLOv5 dataset:
folder
as a split.txt
as a split.folder
as a split.txt
as a split.folder
andtxt
as a split.Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit