-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set_spaces operation #4381
add set_spaces operation #4381
Conversation
WalkthroughThe recent changes aim to streamline workspace management within the application. These updates introduce the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
f2e9587
to
ebe7ee9
Compare
ebe7ee9
to
9773a8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- app/packages/operators/src/built-in-operators.ts (2 hunks)
- fiftyone/operators/builtin.py (1 hunks)
- fiftyone/operators/operations.py (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- app/packages/operators/src/built-in-operators.ts
- fiftyone/operators/operations.py
Additional Context Used
Ruff (1)
fiftyone/operators/builtin.py (1)
53-53: Local variable
sample_ids
is assigned to but never used
Additional comments not posted (1)
fiftyone/operators/builtin.py (1)
449-449
: The integration ofset_spaces
in theLoadWorkspace
class aligns with the PR's objectives to enhance workspace management. Ensure that theset_spaces
method is implemented and tested across all relevant parts of the application.Verification successful
The
set_spaces
method is implemented and utilized across various parts of the FiftyOne application, including operations handling, server mutations, and session management. This confirms the method's integration and alignment with the PR's objectives to enhance workspace management.
- Operations Handling: Defined and triggered in
fiftyone/operators/operations.py
.- Server Mutations: Used in
fiftyone/server/mutation.py
to handle asynchronous server operations.- Session Management: Integrated into session events in
fiftyone/core/session/session.py
and client session handling infiftyone/core/session/client.py
.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation and usage of `set_spaces` across the application. # Test: Search for the `set_spaces` method usage. Expect: Instances across various modules. rg --type py $'set_spaces'Length of output: 615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgTm
What changes are proposed in this pull request?
Add
set_spaces
operation toctx.ops
available in operators executeHow is this patch tested? If it is not, please explain why.
Set workspace
Set arbitrary space
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
See usage above
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit